Split large unions over multiple lines #10219
Draft
+654
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
✔️ Acknowledged. Think of this as the issue, to open the discussion via demonstration.
Please ignore whitespace changes when reviewing this PR.
Description
To make
git
management of changes easier, it's nice if lines aren't too long. Some of the lines emitted by graphql-code-generator can be excessively large which results in hard to review diffs. This PR aims to introduce newline splits in a few more places to make changes more surgical.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tests have been updated.
Test Environment:
master
branchChecklist:
Notes:
TypeScript GraphQL Request tests › works without variables
andTypeScript GraphQL Request tests › returns first 3 entries
tests fail locally for me onmaster
. I have not investigated.Further comments
I've currently gated this behind the
printFieldsOnNewLines
setting which seems related; I don't know if you'd want separate settings for each change, or a more generaluseNewlinesForUnions
setting, or...?This is also not an exhaustive change that adds newlines to all unions.